[Bug 737511] Review request: rubygem-haml-rails - Haml generators for Rails 3

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 20 07:06:34 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737511

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #7 from Vít Ondruch <vondruch at redhat.com> 2011-09-20 03:06:33 EDT ---
* I believe that not every Rails application has to use ActionMailer for
sending
  emails, so the actionmailer is just optional from haml-rails POV.

* Remove unused "testdir" macro

* %{geminstdir}/haml-rails.gemspec should not be marked as %doc

Otherwise the package looks good. So please fix this nits and go ahead with the
Git request. This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list