[Bug 739858] Review Request: python-import-utils - A module that supports simple programmatic module imports

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739858

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2011-09-20 05:30:52 EDT ---
Review:-
+ koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3363681
+ rpmlint output can be ignored as those are only warning messages.
+ source is verified with upstream as (sha1sum)
81c83e19252aa05be2c3d6b8cae0c3da1f94ad26  import-utils-0.0.1.tar.gz
81c83e19252aa05be2c3d6b8cae0c3da1f94ad26  ../SOURCES/import-utils-0.0.1.tar.gz
+ rest looks ok.


Suggestion:
1) you can remove comment line and macros as they are not needed for Fedora
spec
2) also cleaning of buildroot is not required now in fedora.
2)  If you want to import this package for el5 also then have a look at
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines
and http://fedoraproject.org/wiki/Packaging:Python#Macros



APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.