[Bug 727323] Review Request: vios-proxy - Network proxy between a QEMU host and QEMU guests using virtioserial channels

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=727323

--- Comment #9 from Lon Hohberger <lhh at redhat.com> 2011-09-20 15:56:16 EDT ---
# SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it. [25]

N/A; text included

# SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available. [26]

N/A; none available

# SHOULD: The reviewer should test that the package builds in mock. [27]

Rebuilt in mock.  Also submitted to koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3365692
(Note - scratch build)

# SHOULD: The package should compile and build into binary rpms on all
supported architectures. [28]

Rebuilt on i686 on F14.
Koji run against rawhide.

# SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.

Did not test.

# SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity. [29]

N/A none are used.

# SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency. [21]

There is no main package; sub packages are doc or standalone binaries.  It is
my belief that this suggestion does not apply at the moment.

# SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb. [30]

N/A There are no .pc files

# SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself. [31]

PASS

# SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.[32]

This is future work for the package maintainer; the binaries do not have
manual pages.  The -doc package provides documentation in .odt format.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.