[Bug 739088] Review Request: arandr - Simple GTK+ XRandR GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739088

--- Comment #8 from Lubomir Rintel <lkundrak at v3.sk> 2011-09-22 09:35:30 EDT ---
* Package name correct
* Versioning correct
* RPMLint happy
* License is approved for fedora
- License tag correct
* Macros used consistently
- Spec file clean and legible
* American English used
* Filelist sane
* Requires sane
* Provides sane
* Builds fine in mock

1.) %{python_sitelib}/arandr-%{version}-py2.7.egg-info

This is wrong. It will only work for python 2.7, obviously.

2.) Fix your indentation:

Group:  Applications/System
License:  GPLv3
URL:    http://christian.amsuess.com/tools/arandr/
Source0: 
http://christian.amsuess.com/tools/arandr/files/%{name}-%{version}.tar.gz
BuildRoot:  %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
...

3.) Licensing is bad

Files lack any copyright and licensing information at all: e.g.:
screenlayout/xrandr.py screenlayout/meta.py. Needs to be fixed upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.