[Bug 732218] Review Request: travelccm - C++ Travel Customer Choice Model Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732218

--- Comment #2 from Denis Arnaud <denis.arnaud_fedora at m4x.org> 2011-09-23 13:55:56 EDT ---
Thanks for the review!

1. Yes, of course, I will change the specification file name to travelccm.spec.
As a matter of fact, locally, to test the build of the package, I usually do a
symbolic link on the latest version of the specification file (e.g.,
travelccm.spec -> travelccm.spec-0.5.0-1.spec). That avoids confusion around
the version of the specification file.

2. The permissions can be fixed upstream, of course. Indeed, they are already
fixed (I have to check to be 100% sure, but normally, they are). I will remove
that part from the specification file (as it has become useless).

3. For the doc sub-package, I guess that you meant:
  %if ! (0%{?rhel} < 6)
  BuildArch:     noarch
  %endif
It makes sense to me, and I will alter the specification file.

4. About the LGPLv2+ headers, you mean that I should add them into the source
code?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.