[Bug 740955] Review Request: cloud-init - Cloud instance init scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=740955

Dennis Gilmore <dennis at ausil.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

--- Comment #3 from Dennis Gilmore <dennis at ausil.us> 2011-09-23 22:43:24 EDT ---
 rpmlint /var/lib/mock/fedora-16-x86_64/result
cloud-init.src: W: invalid-url Source0: cloud-init-0.6.2-bzr450.tar.gz
cloud-init.noarch: W: non-conffile-in-etc /etc/cloud/cloud.cfg.d/README
cloud-init.noarch: W: no-manual-page-for-binary cloud-init
cloud-init.noarch: W: no-manual-page-for-binary cloud-init-cfg
cloud-init.noarch: W: no-manual-page-for-binary cloud-init-run-module
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

since the tarball is a upstream snapshot to verify the sources i checked out
the sources per the instructions in the spec and did a diff of what is in the
srpm. there was no differences. 


in the %files section you have 
%if 0%{?fedora} > 14
%config(noreplace) %{_sysconfdir}/rsyslog.d/21-cloudinit.conf
%endif

but where your installing the config file you do not have a matching check, you
should also add a Requires for rsyslog and have the check there as well. though
since this is very systemd specific might be best to just drop the check all
together and unconditionaly require rsyslog 

you can chose the way you would like to handle it at import time

Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.