[Bug 732218] Review Request: travelccm - C++ Travel Customer Choice Model Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732218

--- Comment #4 from Denis Arnaud <denis.arnaud_fedora at m4x.org> 2011-09-24 13:29:18 EDT ---
Feedback has been taken into account:

===================================================
Spec URL:
http://denisarnaud.fedorapeople.org/sim/travelccm/travelccm-0.5.0-2.spec
SRPM URL:
http://denisarnaud.fedorapeople.org/sim/travelccm/travelccm-0.5.0-2.fc15.src.rpm
===================================================

Note that:
--------------
 %if ! (0%{?rhel} < 6)
 BuildArch:     noarch
 %endif

does not work on Fedora because %{rhel} is not defined (and therefore the whole
condition holds false).
Hence, I have used:
 %if 0%{?fedora} || 0%{?rhel} > 5
 BuildArch:      noarch
 %endif
--------------

Linking travelccm.spec to travelccm-0.5.0-2.spec, in order to build (with
rpmbuild -bs/-ba) and to test (with rpmlint) RPM packaging, fully works:
rpmlint does not report any warning.

Indeed, it allows me tracking all the different versions for all the review
requests and bugs, in a very convenient way:
https://github.com/denisarnaud/fedorareviews/tree/trunk/sim/travelccm/travelccm_732218
It could give ideas to some other package maintainers :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.