[Bug 740160] Review Request: discount - An implementation of the Markdown language in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=740160

--- Comment #5 from Craig Barnes <cbgnome at gmail.com> 2011-09-25 17:15:56 EDT ---
Sorry about the line wrapping there. I thought Bugzilla allowed manual
wrapping.

I just thought I'd explain the patch I added too, before I forget what it was
for.

The reason I added it is, when the "--shared" flag is passed to configure.sh,
it causes "make install" to run a script bundled by the author called
"librarian.sh". Apparently this is just to "clean up the Makefile" but it also
tries to call ldconfig. I guess this is a legitimate thing to do for people
compiling it themselves but when executed via rpmbuild it gives a fatal
permission error:

>    "/sbin/ldconfig: Can't create temporary cache file /etc/ld.so.cache~: Permission denied"

The patch simply removes the call to ldconfig. I have added %post and %postun
sections to call ldconfig, as detailed in the packaging guidelines. This fix
appears to work, although I'm not 100% sure that this is the correct way to fix
it.

I also read in the packaging guidelines that every patch should be reported
upstream. I can report it but I will wait for some feedback here first about
whether or not the patch is actually the correct thing to do.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.