[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review?

--- Comment #11 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-09-26 03:07:26 EDT ---
Very well. I now see that the rm -rf line is necessary, since for some reason
/etc/init.d is a directory and not a symlink as on installed Fedoras.

Here's my review:

***

rpmlint output:
haveged.src: W: spelling-error %description -l en_US dev -> deb, derv, div
haveged.src: W: spelling-error %description -l en_US cpuid -> cupid
haveged.src: W: spelling-error %description -l en_US stdout -> stout, std out,
std-out
haveged.src:63: W: macro-in-comment %{buildroot}
haveged.src:91: W: macro-in-comment %attr
haveged.src:91: W: macro-in-comment %{_initrddir}
haveged.x86_64: W: spelling-error %description -l en_US dev -> deb, derv, div
haveged.x86_64: W: spelling-error %description -l en_US cpuid -> cupid
haveged.x86_64: W: spelling-error %description -l en_US stdout -> stout, std
out, std-out
haveged.x86_64: W: incoherent-subsys /etc/rc.d/init.d/haveged $prog
3 packages and 0 specfiles checked; 0 errors, 10 warnings.

- Patch0 is missing a comment, still. Please add one in the spec file.
- Please drop the "Apply patches: " comment and the following commented line.
- Please drop the commented line in %files.
- The "spelling-errors" are false alarms.
- Fix the subsystem stuff.


MUST: The spec file for the package is legible and macros are used
consistently.  OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- License is GPLv3+, not GPLv3.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
$ md5sum haveged-1.2.tar.gz ../SOURCES/haveged-1.2.tar.gz 
dc961f36c065239f2ddeeb840ddf9ec0  haveged-1.2.tar.gz
dc961f36c065239f2ddeeb840ddf9ec0  ../SOURCES/haveged-1.2.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A

MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
- ... but *please* don't use wildcards for just one or two files. Change
 %{_mandir}/man8/*
 %{_sbindir}/*
 %{_initrddir}/*
to
 %{_mandir}/man8/haveged.8*
 %{_sbindir}/haveged
 %{_initrddir}/haveged
or the same using %{name}, both of which have the same effect as the wildcard
but make the %files section MUCH clearer.

MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned, architecture dependent dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.