[Bug 740846] Review Request: espresso - Extensible Simulation Package for Research on Soft matter

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 26 11:16:11 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=740846

--- Comment #4 from Thomas Spura <tomspur at fedoraproject.org> 2011-09-26 07:16:11 EDT ---
(In reply to comment #3)
> Please note as well that the MPI binaries should be suffixed _mpich2 and
> _openmpi (these are the corresponding $MPI_SUFFIX), not -mpich2 or -openmpi.

Changed.

> I also don't think shipping libraries without any header files is necessary.
> Please add the relevant headers or don't ship the development libraries at all.

Upstream prefers the later.

%changelog
- use correct MPI_SUFFIX
- don't install library as upstream doesn't support it anymore

Spec URL: http://tomspur.fedorapeople.org/review/espresso.spec
SRPM URL: http://tomspur.fedorapeople.org/review/espresso-3.0.1-3.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list