[Bug 739347] Review Request: haveged - A Linux entropy source using the HAVEGE algorithm. Feed entropy into random pool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739347

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-09-26 18:19:35 EDT ---
(In reply to comment #12)
> > - Patch0 is missing a comment, still. Please add one in the spec file.
> Well, I have added following text to he description already in 
> https://bugzilla.redhat.com/show_bug.cgi?id=739347#c4

... you put it at the end of %description? Well, that's the wrong place to put 
it. When you have a bunch of patches, then you'd like to see what they're for.
For instance:

# Link to foo correctly
Patch0: haveged-1.2.3-foo.patch
# Don't do bar on install
Patch1: haveged-1.2.3-nobar.patch

> haveged.i686: W: incoherent-subsys /etc/rc.d/init.d/haveged ${prog}
> ...... It is also possible
> that rpmlint gets this wrong, especially if the init script contains
> nontrivial shell variables and/or assignments.  These cases usually manifest
> themselves when rpmlint reports that the subsys name starts a with '$'; in
> these cases a warning instead of an error is reported and you should check the
> script manually.
> 
> Init script is indeed using a variable.

OK.


Before commit to git, please remove the patch comment from %description, where
it doesn't serve any purpose, and add a short description of Patch0 as above.

This package has been

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.