[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732552

Eric Varsanyi <fedora62 at foo21.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora62 at foo21.com

--- Comment #27 from Eric Varsanyi <fedora62 at foo21.com> 2011-09-26 19:21:14 EDT ---
The spec file in http-parser (from bug 741137) creates a .o file only rather
than a library. Below is a hack (to illustrate only) to the node js's cmake
input to link with this .o rather than the expected shared or static lib
(apologies for my lack of cmake foo):

d2 ~/rpmbuild/BUILD$ cat ../SOURCES/nodejs-static-http.patch 
diff -Naur node-v0.4.12.ORIG/cmake/libhttp_parser.cmake
node-v0.4.12/cmake/libhttp_parser.cmake
--- node-v0.4.12.ORIG/cmake/libhttp_parser.cmake 2011-09-26 15:07:53.787962674
-0500
+++ node-v0.4.12/cmake/libhttp_parser.cmake 2011-09-26 18:11:38.807130936 -0500
@@ -1,10 +1,10 @@
 if(SHARED_HTTP_PARSER)
-  find_library(HTTP_PARSER_LIBRARY NAMES http_parser)
+  find_file(HTTP_PARSER_OBJ http_parser.o PATHS /usr/lib64/http-parser)
   find_path(HTTP_PARSER_INCLUDE_DIR http_parser.h
-    PATH_SUFFIXES include
+    PATH_SUFFIXES include/http-parser
     ) # Find header
-  find_package_handle_standard_args(http_parser DEFAULT_MSG
HTTP_PARSER_LIBRARY HTTP_PARSER_INCLUDE_DIR)
+  find_package_handle_standard_args(http_parser DEFAULT_MSG HTTP_PARSER_OBJ
HTTP_PARSER_INCLUDE_DIR)
 else()
   add_subdirectory(deps/http_parser)
   set(HTTP_PARSER_INCLUDE_DIR deps/http_parser)
-endif()
\ No newline at end of file
+endif()
diff -Naur node-v0.4.12.ORIG/cmake/node_build.cmake
node-v0.4.12/cmake/node_build.cmake
--- node-v0.4.12.ORIG/cmake/node_build.cmake 2011-09-26 15:07:53.787962674
-0500
+++ node-v0.4.12/cmake/node_build.cmake 2011-09-26 18:08:09.811284914 -0500
@@ -112,7 +112,7 @@
   ev
   eio
   cares
-  http_parser
+  ${HTTP_PARSER_OBJ}
   ${V8_LIBRARY_PATH}
   ${CMAKE_THREAD_LIBS_INIT}
   ${extra_libs})

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.