[Bug 718681] Review Request: luajit - Just-In-Time Compiler for Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=718681

--- Comment #6 from john5342 <john5342 at gmail.com> 2011-09-27 12:15:42 EDT ---
Just a few initial notes looking at the spec file:


The actual shared library (libluajit-5.1.so.2.*) is in the main package as it
should be but libluajit-5.1.so should only be used for linking against and
should therefore be in the devel package.


The buildroot tag is not one of the standard ones so far as i remember but
either way it has not been needed for some time now and is ignored on our build
system.


The hotfix patch (which is obviously upstream) should be provided as a full URL
just like the source package.


%{optflags} must always be used. Adding CFLAGS="%{optflags}" to the build
commandline should do the trick according to the in Makefile documentation.


All build output should be in verbose mode to aid in debugging failed builds as
well as verifying that correct flags are used. I don't know of an easy way with
these hand written Makefiles but it certainly should be investigated.


A quick build and rpmlint of the resulting output:
$ rpmlint luajit-*.rpm
luajit.x86_64: W: shared-lib-calls-exit /usr/lib64/libluajit-5.1.so.2.0.0
exit at GLIBC_2.2.5

Can probably be ignored since it is required to implement os.exit()

luajit.x86_64: W: no-manual-page-for-binary luajit-2.0.0-beta8

Not ideal but upstream don't provide one.

luajit-debuginfo.x86_64: E: empty-debuginfo-package

This is an error. Not sure if it is because it's failing to pick up the debug
options in %{optflags} or something else but difficult to tell without knowing
what commands are run.

luajit-devel.x86_64: W: no-documentation

devel requires the main package which does contain docs

luajit-static.x86_64: W: spelling-error %description -l en_US libluajit ->
liberality

Ignore

luajit-static.x86_64: W: no-documentation

Same as above

5 packages and 0 specfiles checked; 1 errors, 5 warnings.



If these things are sorted i can probably do a proper review when i get some
time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.