[Bug 807017] Review Request: ovirt-engine - Management server for Open Virtualization

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 1 12:04:34 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807017

--- Comment #7 from Juan Hernández <juan.hernandez at redhat.com> 2012-04-01 08:04:32 EDT ---
The spec has been updated to fix most of the errors detected during the review
that Ofer did. The updated .src.rpm is available here:

http://jhernand.fedorapeople.org/rpms/ovirt-engine-3.0.0-9.0001.fc18.src.rpm

The updated package builds correctly in Koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3954397

There are still rpmlint warnings and also some errors that can't be avoided,
but can be explained:

ovirt-engine.noarch: E: non-readable /etc/ovirt-engine/engine.conf 0640L
ovirt-engine-iso-uploader.noarch: E: non-readable
/etc/ovirt-engine/isouploader.conf 0600L
ovirt-engine-log-collector.noarch: E: non-readable
/etc/ovirt-engine/logcollector.conf 0600L
ovirt-engine-notification-service.noarch: E: non-readable
/etc/ovirt-engine/notifier/notifier.conf 0640L

These file need restrictive read permissions because they may contain
passwords.

ovirt-engine-log-collector.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/sos/plugins/postgresql.py
ovirt-engine-log-collector.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/sos/plugins/jboss.py
ovirt-engine-log-collector.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/sos/plugins/engine.py

These files have no shebang and execution permissions like all the other SOS
plugins.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list