[Bug 809114] Review Request: novacomd - Utility to connect to WebOS devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809114

Mohamed El Morabity <pikachu.2014 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pikachu.2014 at gmail.com

--- Comment #1 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-04-02 10:22:41 EDT ---
I'd be glad to review it, since I'm having a WebOS device. Just some comments:
- %defattr in %files is useless now:
   http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
- %clean section, as well as buildroot cleaning in %install and the BuildRoot
tag, is useless too:
   http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
   http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- it looks like the sources provide an Upstart service file. This service was
also available in the binary packages delivered by HP:
  
https://developer.palm.com/content/resources/develop/sdk_pdk_download.html#linux
   I think you should write a very simple Systemd file to launch novacomd at
startup for this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.