[Bug 810059] opencl-utils - Useful OpenCL tools and utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810059

Alec Leamas <leamas.alec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leamas.alec at gmail.com

--- Comment #1 from Alec Leamas <leamas.alec at gmail.com> 2012-04-05 04:13:20 EDT ---
Just some initial remarks, no references (drop a line if need be).
- Package does not build in mock. Patch below fixes.
- As for the missing doc, file a bug upstream to add the license file.
- The examples might just go into -devel IMHO.
- You need to somehow use %{optflags} in the Makefile.
- Makefile contains a 'strip' command which should be removed.
- opencl-utils-debuginfo.i686: E: empty-debuginfo-package related to above.
- Since this a library intended to be used by other programs, the Makefile
should be patched to include a soname (a %global macro), and symlinks setup
accordingly. That patch should be acceptable upstream.
- The description for -devel says 'source code'; shouldn't that be 'header
files'?
- The debug package name opencl-utils-debuginfo is not consistent w the others.


--- *spec.ORG 2012-04-05 09:16:17.211177855 +0200
+++ opencl-utils.spec 2012-04-05 09:17:25.477104941 +0200
@@ -18,6 +18,8 @@

#http://code.google.com/p/dolphin-emu/source/browse/Externals/CLRun/clrun/generateClRun.pl
 Patch1:         %{name}-trimwhitespace.patch

+BuildRequires: mesa-libGL-devel
+
 %package     -n CLRun
 Summary:        Dynamic loader for OpenCL

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.