[Bug 810928] Review Request: sticky-notes - Sticky notes is a free and open source paste-bin application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=810928

--- Comment #3 from Kevin Fenzi <kevin at scrye.com> 2012-04-10 14:49:48 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
See below - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. There seem to be two bundled projects in addons: 

geshi - http://qbnz.com/highlighter/ (already packaged as php-geshi)
jquery - under review at https://bugzilla.redhat.com/show_bug.cgi?id=805587

Should require those and fix it work with them. 

2. Probibly shouldn't Requires mysql-server. It's very likely that someone
could have 
their database on a remote machine and just install this on a frontend. 

3. rpmlint says: 

sticky-notes.src: W: invalid-url Source0: sticky-notes-20120407git.tar

Can be ignored. 

4. Non package blockers, but suggestions for upstream: 

- Add possiblity to use captchas on configurable kinds of pastes. 
- Add possiblity to blacklist some words in pastes to block spam (Viagra, etc)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.