[Bug 812121] Review Request: python-kmod - Load, unload & list kernel modules from Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812121

Tomas Edwardsson <tommi at tommi.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tommi at tommi.org

--- Comment #1 from Tomas Edwardsson <tommi at tommi.org> 2012-04-16 20:30:04 EDT ---
This is a Informal Review.


MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces.  [FIX]


rpmlint returns various errors:

private-shared-object-provides - the dependency for kmod-libs is automatically
generated so you should remove it from the spec file.
incorrect-fsf-address, see http://www.gnu.org/licenses/lgpl-2.1.html
spelling-error I believe you can safely ignore this
non-standard-executable-perm - seems to conform to other python packages


rpmlint python-kmod-debuginfo-0.1-1.fc17.x86_64.rpm

python-kmod-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/agrover-python-kmod-74467e0/libkmod.c
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

rpmlint python-kmod-0.1-1.fc17.x86_64.rpm

python-kmod.x86_64: E: explicit-lib-dependency kmod-libs
python-kmod.x86_64: W: spelling-error %description -l en_US libkmod -> libido
python-kmod.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/kmod.so kmod.so()(64bit)
python-kmod.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.7/site-packages/kmod.so 0775L
python-kmod.x86_64: E: incorrect-fsf-address
/usr/share/doc/python-kmod-0.1/COPYING
python-kmod.x86_64: E: incorrect-fsf-address
/usr/share/doc/python-kmod-0.1/COPYING.LESSER
1 packages and 0 specfiles checked; 3 errors, 2 warnings.


python-kmod.src: W: spelling-error %description -l en_US libkmod -> libido
The value of this tag appears to be misspelled. Please double-check.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.


MUST: The License field in the package spec file must match the actual license.
  [FIX]

The License specified in the spec file is MIT but it looks like LGPLv2+ is more
appropriate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.