[Bug 813433] Review Request: dt - A generic data test program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=813433

Milan Broz <mbroz at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mbroz at redhat.com

--- Comment #1 from Milan Broz <mbroz at redhat.com> 2012-04-18 07:45:31 EDT ---
I am using this test for dmcrypt, so will try to review it:

Issues

- remove rm -rf $RPM_BUILD_ROOT

- separate documentation perhaps?

[!]: MUST Rpmlint output is silent.

rpmlint dt-16.08-1.fc18.i686.rpm

dt.i686: W: spelling-error %description -l en_US config -> con fig, con-fig,
configure
dt.i686: W: wrong-file-end-of-line-encoding
/usr/share/doc/dt-16.08/WindowsTesting.txt

- maybe recode text or do not install it at all for Fedora?

dt.i686: W: no-manual-page-for-binary dt
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

- I know there is no man page upstream, but perhaps add at least some basic
info?

rpmlint dt-debuginfo-16.08-1.fc18.i686.rpm

dt-debuginfo.i686: E: empty-debuginfo-package
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

- please fix build so debuginfo is usable

rpmlint dt-16.08-1.fc18.src.rpm

dt.src: W: spelling-error %description -l en_US usr -> use, us, user
dt.src: W: spelling-error %description -l en_US config -> con fig, con-fig,
configure
dt.src: W: invalid-url Source0: dt-source.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

(I know upstream availability is here problem, so this is perhaps exception.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.