[Bug 812674] Review Request: gnome-nettool - Graphical front-ends to various networking command-line tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=812674

Richard Shaw <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |hobbes1069 at gmail.com
         AssignedTo|nobody at fedoraproject.org    |hobbes1069 at gmail.com

--- Comment #1 from Richard Shaw <hobbes1069 at gmail.com> 2012-04-18 14:32:45 EDT ---
I'll take this one.

Quick spec review:
1. %global is preferred over %define[1].

2. I've never seen desktop-file-validate put in %check. I think that's usually
for "make test" type unit testing to kill builds that fail their tests even if
they build. I usually put it in %install. 

Otherwise looks good. Now off the building...

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.