[Bug 813414] Review Request: drupal6-better_formats - Better formats is a module to add more flexibility to Drupal's core input format system.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=813414

--- Comment #6 from Wesley Hearn <whearn at redhat.com> 2012-04-20 14:50:02 EDT ---
Good: MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[0]whearn at Doom:~/rpmbuild $ rpmlint
SRPMS/drupal6-better_formats-1.2-3.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[02:20 PM]
[0]whearn at Doom:~/rpmbuild $ rpmlint
RPMS/noarch/drupal6-better_formats-1.2-3.fc16.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[02:20 PM]
[0]whearn at Doom:~/rpmbuild $ rpmlint SPECS/drupal6-better_formats.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Good: MUST: The package must be named according to the Package Naming
Guidelines .
Good: MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.
Good: MUST: The package must meet the Packaging Guidelines .
Good: MUST: The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines .
Good: MUST: The License field in the package spec file must match the actual
license.
See Note: MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
Good: MUST: The spec file must be written in American English.
Good: MUST: The spec file for the package MUST be legible.
Good: MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
[02:42 PM]
[0]whearn at Doom:~/Downloads $ md5sum better_formats-6.x-1.2.tar.gz 
4691f68977cb5d50eb782b1c14ec79ba  better_formats-6.x-1.2.tar.gz
[02:42 PM]
[0]whearn at Doom:~/Downloads $ md5sum
~/rpmbuild/SOURCES/better_formats-6.x-1.2.tar.gz
4691f68977cb5d50eb782b1c14ec79ba 
/home/whearn/rpmbuild/SOURCES/better_formats-6.x-1.2.tar.gz

noarch: MUST: The package MUST successfully compile and build into binary rpms
on at least one primary architecture.
noarch: MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
Good: MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
Good: MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
noarch: MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
Good: MUST: Packages must NOT bundle copies of system libraries.
Good: MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. 
Good: MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
Good: MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
Good: MUST: Permissions on files must be set properly. Executables should be
set with executable permissions, for example.
Good: MUST: Each package must consistently use macros.
Good: MUST: The package must contain code, or permissable content.
Good: MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
Good: MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.
noarch: MUST: Static libraries must be in a -static package.
Good: MUST: Development files must be in a -devel package.
not needed: MUST: In the vast majority of cases, devel packages must require
the base package using a fully versioned dependency: Requires: %{name}%{?_isa}
= %{version}-%{release}
Good: MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
Good: MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
Good: MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
Good: MUST: All filenames in rpm packages must be valid UTF-8.

License note: Can you submit a patch upstream so they can fix it there, other
then that it looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.