[Bug 814887] Review Request: encuentro - Content visualization of the Canal Encuentro.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=814887

--- Comment #4 from Adrian Alves <aalves at gmail.com> 2012-04-20 23:40:41 EDT ---
I fixed all that you suggest and I added the new versions into my fedorapeople
new spec and new src.rpm

(In reply to comment #1)
> Some comments:
> 
> Is this your first package?  Do you require a sponsor?
> 
> BuildRoot: is unnecessary unless you play to build for RHEL5.  And if you do,
> you'll need to add cleaning of the buildroot in %install.
> 
> You can not use Prefix:, Packager:, or Vendor: in Fedora.
> 
> An empty %build is not actually required.  (Maybe for RHEL5; I'm not sure.)
> 
> %clean is not required (except for RHEL5, again).
> 
> %defattr(-,root,root) is not required; you only need it if you're specifying a
> non-default value.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.