[Bug 815018] Review Request: nodejs - javascript fast build framework

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 24 08:48:38 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815018

--- Comment #26 from T.C. Hollingsworth <tchollingsworth at gmail.com> 2012-04-24 04:48:35 EDT ---
There are several issues here:

* Node bundles a library created by the same upstream called libuv, which
basically abstracts networking, filesystem, the event loop, etc. between *nixes
and Windows.  That library presently includes bundled copies of libev, libeio,
and libc-ares.  All three have out-of-tree patches, so it isn't currently
possible to use system versions of these libraries with Node.  AFAIK this is a
blocker, so you might as well stop here, but...

* You don't even use the shared libraries upstream does support.  See
`./configure --help` and my spec file [1] for info on how to this.  You'll also
have to coordinate with Tom Callaway and Thomas Spura on what to do about V8. 
Chromium and Node require different versions, though it's possible to build a
parallel-installable compat version, as I'm doing for F17 [2].

* There is a file conflict with the /usr/bin/node shipped by the "node" package
in Fedora.  I rename everything to "nodejs" to avoid this, and there are
several patches in my SRPM [3] that make Node happy with this.

* Node includes a copy of npm, which is also a violation of the bundling
policy.  You must build node with `--without-npm` and package npm separately.

[1] http://nodejs.tchol.org/specs/nodejs.spec
[2]
http://nodejs.tchol.org/stable/f17/SRPMS/compat-v8-3.6-3.6.6.24-1.fc17.src.rpm
[3] http://nodejs.tchol.org/stable/f16/SRPMS/nodejs-0.6.15-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list