[Bug 815989] Review Request: python-routes1.12 - Rails-like routes for Python
bugzilla at redhat.com
bugzilla at redhat.com
Wed Apr 25 21:41:52 UTC 2012
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=815989
Alan Pevec <apevec at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apevec at gmail.com
Flag| |fedora-review+
--- Comment #2 from Alan Pevec <apevec at gmail.com> 2012-04-25 17:41:52 EDT ---
This is based on existing package: compared to rawhide, only change is parallel
installation.
=> APPROVED
MUST
OK rpmlint
=>
python-routes1.12.noarch: W: hidden-file-or-dir
/usr/share/doc/python-routes1.12-1.12.3/docs/_build/html/.buildinfo
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
This warning is not critical and appears with rawhide too.
OK name
OK spec
file name = %{name}.spec
American English
legible
locales %find_lang
UTF-8 filenames
OK Packaging Guidelines
OK license
Fedora approved
spec field
in %doc
OK sources
url
=> wget http://pypi.python.org/packages/source/R/Routes/Routes-1.12.3.tar.gz
md5sum
=> echo "9740ff424ff6b841632c784a38fb2be3 Routes-1.12.3.tar.gz" | md5sum -c
Routes-1.12.3.tar.gz: OK
OK BuildRequires
OK directories
own all or require a package
no directory conflicts
OK no dups in %files (exception: license texts)
OK Permissions
OK consistently use macros
OK code or permissable content
SHOULD
OK build in mock
=> http://koji.fedoraproject.org/koji/taskinfo?taskID=4023177
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list