[Bug 814719] Review Request: lcg-infosites - Command line tool in Perl for the LCG information system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=814719

--- Comment #10 from Steve Traylen <steve.traylen at cern.ch> 2012-04-26 07:32:13 EDT ---
A few extra things:

(1)
Requires:                       perl
Requires:                       perl(Net::LDAP)

should not be present since they are auto determined.

(2)
* Fri Apr 20 2012 Adrien Devresse <adevress at cern.ch> -  3.1.0-2%{?dist}

is not correct. See: 
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

(3)
BuildRoot:                      %{_tmppath}/%{name}-%{version}-build
is an incorrect build root, see:

http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines

(4) '/'?
Why is there a '/' in the decription:

lcg-infosites is a simple command line tool in Perl for \
the lcg information system

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.