[Bug 801064] Review Requst: fcitx-ui-light - Light UI for Fcitx

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=801064

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2012-04-26 10:34:26 EDT ---
Review:-
+ koji scratch build for f17
->http://koji.fedoraproject.org/koji/taskinfo?taskID=4024907

+ rpmlint on rpms gave
fcitx-ui-light.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 5)
fcitx-ui-light.src: W: invalid-url Source0:
http://fcitx.googlecode.com/files/fcitx-ui-light-0.1.3.tar.bz2 HTTP Error 404:
Not Found
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ Source verified with upstream as (sha1sum)
016c980866619019792d775be1fa0c9ca5278994  fcitx-ui-light-0.1.3.tar.bz2
016c980866619019792d775be1fa0c9ca5278994 
../SOURCES/fcitx-ui-light-0.1.3.tar.bz2

+ Package : fcitx-ui-light-0.1.3-1.fc17.x86_64
Provides: fcitx-light-ui.so()(64bit)
Requires: libX11.so.6()(64bit) libXft.so.2()(64bit) libXpm.so.4()(64bit)
libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libfontconfig.so.1()(64bit)
rtld(GNU_HASH)

Suggestions:-
1) Fix the rpmlint messages. 
  a) mixed-use-of-spaces-and-tabs message can be fixed using command
     sed -i 's|\t| |g' fcitx-ui-light.spec

2) If package is only for Fedora then no need to add
  a) %clean section (see
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)
  b) removal of buildroot in %install (remove line rm -rf $RPM_BUILD_ROOT)
  c) remove line %defattr(-,root,root,-)

3) please don't use commands in macro that is change %{__mkdir} to "mkdir"

4) package should add Requires: fcitx, fcitx-data

5) Use following commands in %build
%cmake ..
make VERBOSE=1 %{?_smp_mflags}

6) %install should preserve timestamp using 
   make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

7) Add COPYING AUTHORS to %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.