[Bug 809116] Review Request: novacom-client - Utility to connect to WebOS devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809116

Jonathan Dieter <jdieter at lesbg.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwmw2 at infradead.org
          Component|Package Review              |0xFFFF
         AssignedTo|pikachu.2014 at gmail.com      |dwmw2 at infradead.org

--- Comment #4 from Jonathan Dieter <jdieter at lesbg.com> 2012-04-26 14:04:36 EDT ---
(In reply to comment #3)
> You should add a comment to describe the way the sources can be retrieved, or
> provide a direct URL to get them (as in novacom-server).

Fixed.  Unfortunately, openwebos hasn't done a release of novacom (unlike
novacom-server).

> You should use %global instead of %define here:
>   
> http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

Fixed.

> Since gcc is part of the implicit BuildRequires, you don't need to add
> glibc-devel to the list of BR:
>    http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Fixed.

> It looks like the client sources include parts of libtomcrypt (see files
> src/base64.*). Fortunately, they're not used by novacom. I wonder if it's worth
> deleting them.

I figured it was worth it, so I went ahead and patched src/base64* out of the
makefile and main.c, and remove them in the spec file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.