[Bug 815814] Review Request: rubygem-paranoia - re-implementation of acts_as_paranoid for Rails3 that uses much less code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815814

--- Comment #15 from Steve Linabery <slinaber at redhat.com> 2012-04-27 15:38:31 EDT ---
Thank you for all the helpful advice!

Revised spec:
http://slinabery.fedorapeople.org/paranoia/f17/rubygem-paranoia.spec

A patch which details the edits I made:
http://slinabery.fedorapeople.org/paranoia/f17/0001-specfixes.patch

A revised SRPM:
http://slinabery.fedorapeople.org/paranoia/SRPMS/rubygem-paranoia-1.1.0-1.fc15.src.rpm
(rpmlint passes cleanly on this)

koji scratch build succeeds:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4029628

Additional comments:
1) I emailed a patch to upstream that adds COPYING file containing MIT License
text[1]

2) I had already moved Gemfile* back into %files doc prior to comment #13

3) Note that I have patched out the use of profanity, and that upstream
confirms it has been removed from the source for future releases[2]. In
addition, the description attribute has been improved.

4) I removed the test subdirectory based on [3] ('Do not ship tests'). I did
not add them to the %check section because they require use of rake.

Thanks again, and please advise of any additional requirements.

[1]http://fedoraproject.org/wiki/Licensing:MIT#Modern_Variants
[2]https://github.com/radar/paranoia/commit/ab2b11802e9e2ddb6c110ce7e5484934fb538249
[3]http://fedoraproject.org/wiki/Packaging:Ruby#Running_test_suites

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.