[Bug 815814] Review Request: rubygem-paranoia - re-implementation of acts_as_paranoid for Rails3 that uses much less code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815814

--- Comment #17 from Vít Ondruch <vondruch at redhat.com> 2012-04-30 08:45:31 EDT ---
Steve,

Please always update the release number, even between reviews. It is easier to
track the changes, since I have previous SRPM on my computer anyway. It also
prevents some possible mistakes.

(In reply to comment #16)
> Does this satisfy the SHOULD from comment #14 ?

This looks good, but it is just "SHOULD", so it should not be show-stopper in
any case. It is just recommendation.

Note that if the LICENSE field will be in the main package, you can again move
the README.md back into -doc subpackage. Sorry for that, I was not aware that
you will so promptly convince upstream to include the LICENSE file :)

(In reply to comment #15)
> 4) I removed the test subdirectory based on [3] ('Do not ship tests'). I did
> not add them to the %check section because they require use of rake.

No need to use Rake. Just add following BR:

BuildRequires: rubygem(minitest)
BuildRequires: rubygem(sqlite3)
BuildRequires: rubygem(activerecord)

And subsequently you can run the test suite in check section:

$ RUBYOPT="-rfileutils" testrb test/*

Note that the RUBYOPT="-rfileutils" shouldn't be needed and should be reported
upstream as an error.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.