[Bug 785943] Review Request: gunicorn - Python WSGI application server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785943

--- Comment #4 from Dan Callaghan <dcallagh at redhat.com> 2012-01-31 20:04:12 EST ---
Thanks for taking this review Bohuslav!

(In reply to comment #3)
> - The package should be named python-gunicorn.

At first I picked gunicorn and not python-gunicorn, because the package is a
binary and not a Python library. But now that I read the guidelines more
closely I see that you're right -- gunicorn is really an "addon" package for
Python because it's not useful without a Python WSGI application to run.

> - I think that Group: should be "System Environment/Daemons", as it is with
> other web servers like apache or httpd (not sure if this can actually run as a
> daemon, but I suppose it can).

That makes sense. It is possible (and intended) to run gunicorn as a daemon,
although I personally am not using it that way. Actually it should be easy to
write a systemd unit for it. I will do that and add it to this package.

> - You should have BR: python2-devel according to [1].
> - You should probably rather BR: python-setuptools than
> python-setuptools-devel: it seems to me, that the trend is to move to
> python-setuptools, as the package python-setuptools obsoletes
> python-setuptools-devel and only provides it for backward compatibility.

I have been living in RHEL5-land for too long :-) I will fix these up.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.