[Bug 785371] Review Request: speed-dreams - a fork of TORCS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785371

Alec Leamas <leamas.alec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leamas.alec at gmail.com

--- Comment #8 from Alec Leamas <leamas.alec at gmail.com> 2012-02-01 09:23:54 EST ---
Hi Martin!

I'm not a reviewer, but I can maybe help you a little. 

First of all: you need to get the URL:s to the spec and src rpm in shape. You
have attached the spec file, and it works right now. However, in the long run
URL:s to the source (which is fine ATM) and the spec should work. Each time you
change anything, provide new URL:s (and don't forget to update the release # in
the spec file).

You don't have to attach patches etc, they are all accessible in the srpm. 

Secondly, to others listening: this srpm is huge, roughly 1GB.

Third, someone needs to change the subject line to something like "Review
request: speed-dreams - The Open Racing Car Simulator". I don't know if you can
edit the subject line, otherwise a Fedora admin will certainly fix this. This
is important to attract reviewers (which are not always easily found).

After a fast look at the spec file and source, it looks basically fine besides
nit-picking details  in my not so experienced eyes.

One thing you will have to handle is that some source files have a Mozilla
license (MPL 1.0), which is not compatible with GPLv2. Have a look into
http://fedoraproject.org/wiki/Packaging:Guidelines#Licensing as a beginning.

Good luck!

--alec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.