[Bug 785946] Review Request: python-django-horizon - Django application for talking to Openstack

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 1 15:53:27 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785946

Cole Robinson <crobinso at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |django-horizon - Django     |python-django-horizon -
                   |application for talking to  |Django application for
                   |Openstack                   |talking to Openstack

--- Comment #2 from Cole Robinson <crobinso at redhat.com> 2012-02-01 10:53:27 EST ---
Spec URL: http://fedorapeople.org/~crobinso/reviews/python-django-horizon.spec
SRPM URL:
http://fedorapeople.org/~crobinso/reviews/python-django-horizon-2012.1-0.1.e3.fc16.src.rpm

Changes since v1:
- Changed name to python-django-horizon
- Changes to http conf to make it all actually work (thanks to dhiggins)
- Deps are in rawhide so mock build now works

Current RPMlint

openstack-dashboard.noarch: W: no-documentation

Not a blocker IMO

openstack-dashboard.noarch: E: python-bytecode-inconsistent-mtime
/usr/share/openstack-dashboard/local/local_settings.pyc 2012-02-01T10:42:39
/etc/openstack-dashboard/local_settings 2012-02-01T10:42:55

I don't know what to do about this:
/usr/share/openstack-dashboard/local/local_settings.py is a symlink to
/etc/openstack-dashboard/local_settings.py. Seems to cause the mtimes to get
confused. Long run I want to enable this behavior in upstream, but for now this
seems like a reasonable hack. I don't think the above problem should cause any
problems AFAIK.

python-django-horizon.noarch: W: no-documentation

Not a blocker IMO (though there is a doc subpackage...)

python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/instances/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/flavors/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/services/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/nova/instances_and_volumes/volumes/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/images/tests.py
python-django-horizon.noarch: E: zero-length
/usr/lib/python2.7/site-packages/horizon/dashboards/syspanel/quotas/tests.py

This stubs need to be there to appease upstream tests. We could rip them out
with a patch but that sounds more dangerous than the alternative of just
leaving them in.

python-django-horizon.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/horizon/dashboards/settings/templates/settings/tenant/openrc.sh.template
0644L /bin/bash

This file is actually a template that is used to generate a bash script that is
shown to the user in the UI for them to copy to a local file and run. As such
it shouldn't be executable, but it should have the #!/bin/bash header that
causes rpmlint to think it should be a script. So not a blocker IMO

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list