[Bug 786594] Review Request: beefy-miracle-backgrounds - Beefy Miracle desktop backgrounds

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=786594

--- Comment #6 from Martin Sourada <martin.sourada at gmail.com> 2012-02-02 10:41:50 EST ---
(In reply to comment #4)
> Package Review
> ==============
> Issues:
> [!]: MUST Buildroot is not present
>      Note: Buildroot is not needed unless packager plans to package for EPEL5
> [!]: MUST Each %files section contains %defattr if rpm < 4.4
>      Note: defattr(....) present in %files kde section. This is OK if
>      packaging for EPEL5. Otherwise not needed
As I understand the guidelines it is not a requirement to not include buildroot
and defattr, but I can remove them if you insist.

> [!]: MUST Package contains a properly installed %{name}.desktop using desktop-
>      file-install file if it is a GUI application.
It's not a GUI application.

> [!]: MUST Rpmlint output is silent.
> 
The no-doc and dangling symlink warnings are actually satisfied by deps.

> beefy-miracle-backgrounds.noarch: W: incoherent-version-in-changelog 16.90.1-1
> ['16.91.0-1.fc17', '16.91.0-1']
This is a typo and I'll fix it when I get home.

Hope I didn't missed anything.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.