[Bug 785619] Review Request: lutok - Lightweight C++ API library for Lua

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785619

--- Comment #4 from Michel Alexandre Salim <michel+fdr at sylvestre.me> 2012-02-03 08:59:38 EST ---
Hi Julio,

(note: you forgot to update the SRPM, but the spec looks really close now)

- %{_libdir}/liblutok.so.0 should be in the main package, not in -devel. only
*.so should go to devel

- The html and examples files are still ending up in the main package. Try
installing them to %{_defaultdocdir}/%{name}-doc-%{version} instead

%doc behavior is a bit confusing indeed. I'm pretty sure files in
%{_defaultdocdir}/%{name}-%{version} automatically get registered as part of
the package, and files tagged as %doc without absolute paths get copied there.

- BuildRoot declaration, and cleanup in %install, can be removed

- %files devel should have %{_includedir}/lutok/ _without_ the trailing *.
With,
  you're telling RPM to own the files but not the directory itself

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.