[Bug 783825] Review Request: suil - A lightweight C library for loading and wrapping LV2 plugin UIs

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 6 13:09:46 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=783825

--- Comment #9 from Brendan Jones <brendan.jones.it at gmail.com> 2012-02-06 08:09:45 EST ---
(In reply to comment #8)
> > %files devel
> > %{_libdir}/lib%{name}*.so
> > %{_libdir}/suil-*/libsuil_gtk2_in_qt4.so
> > %{_libdir}/suil-*/libsuil_qt4_in_gtk2.so
> > %{_libdir}/pkgconfig/%{name}*.pc
> > %{_includedir}/%{name}*/
> > ...
> 
> Please review  http://fedoraproject.org/wiki/Packaging:UnownedDirectories  as
> there are several unowned directories in this %files list.
> 
> > %files devel
> > ...
> > %{_libdir}/suil-*/libsuil_gtk2_in_qt4.so
> > %{_libdir}/suil-*/libsuil_qt4_in_gtk2.so
> 
> Highly dubious to put these into the -devel package. Please prove that these
> are not dynamically loaded plugins/modules.
Quite right, they're the point of the package after all :)

SRPM:  http://bsjones.fedorapeople.org/lv2/suil-0.4.4-3.fc16.src.rpm
SPEC:  http://bsjones.fedorapeople.org/lv2/suil.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list