[Bug 787713] Review request: free-solid

bugzilla at redhat.com bugzilla at redhat.com
Mon Feb 6 19:07:49 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787713

--- Comment #2 from Volker Fröhlich <volker27 at gmx.at> 2012-02-06 14:07:48 EST ---
Contrary to what README, license is noted as LGPLv2+, see licensecheck -r
<some_dir>.

I think the devel sub-package has to require pkgconfig, but I can't find that
in the rules right now.

The devel package needs %{?_isa}, see
http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

I suggest to use the name macro in the files section as well, as you're using
it in other places.

You might want to include the sample dir as documentation to the devel package.

The build fails for me on F16 x86_64:

...
+ autoreconf -i
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
configure.in:26: required file `../ltmain.sh' not found
autoreconf: automake failed with exit status: 1
error: Bad exit status from /var/tmp/rpm-tmp.40wZ5K (%build)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list