[Bug 784945] Review Request: ktp-common-internals - Common internals for KDE Telepathy

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 7 01:20:31 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784945

nucleo <alekcejk at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from nucleo <alekcejk at googlemail.com> 2012-02-06 20:20:30 EST ---
name: ok
summary: ok
license: ok
BuildRequires: ok
devel requires main package; ok
handling locale files: ok
/sbin/ldconfig in %post/%postun: ok

The only issue is unneeded commented lines:
#{_kde4_datadir}/kde4/services/kcm_telepathy_accounts.desktop
#{_kde4_datadir}/kde4/servicetypes/kcmtelepathyaccounts-accountuiplugin.desktop
#{_kde4_datadir}/kde4/services/kcmtelepathyaccounts_plugin_sunshine.desktop
#{_kde4_libdir}/kde4/kcmtelepathyaccounts_plugin_butterfly.so

Please remove them before commit.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list