[Bug 784958] Review Request: ktp-text-ui - Telepathy text chat handler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784958

nucleo <alekcejk at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |alekcejk at googlemail.com
               Flag|                            |fedora-review?

--- Comment #1 from nucleo <alekcejk at googlemail.com> 2012-02-06 20:52:25 EST ---
name: ok
summary: ok
handling locale files: ok

BuildRequires:
BR: telepathy-qt4-devel is not needed here because ktp-common-internals-devel
requires it.

/sbin/ldconfig in %post/%postun:
There is libktpchat.so installed in libdir so /sbin/ldconfig is needed.
Other libktpchat.so related issue is invalid-soname rpmlint error.

license:
Code looks like is GPLv2+ but
there is in data/styles/renkoo.AdiumMessageStyle/Contents/Resources/Renkoo
LICENSE.txt:

The images, css and html is dual licensed under the BSD and AFL license.
The source files for the bubbles can be found at http://www.itorrey.com/adiumx/

The fading javascript is not covered in this license. The code is fadomatic and
is covered under its own license as set by its author.


in data/styles/simkete/Contents/README:
This Adium style is released under MIT/X11 license

rpmlint output:
ktp-text-ui.i686: E: invalid-soname /usr/lib/libktpchat.so libktpchat.so
ktp-text-ui.i686: E: zero-length
/usr/share/kde4/apps/ktelepathy/styles/simkete/Contents/Resources/Header.html
ktp-text-ui.i686: E: zero-length
/usr/share/kde4/apps/ktelepathy/styles/simkete/Contents/Resources/Footer.html
3 packages and 0 specfiles checked; 3 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.