[Bug 787834] Review Request: fishpoll - Client programs for fishpoll server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787834

Ofer Schreiber <oschreib at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oschreib at redhat.com

--- Comment #1 from Ofer Schreiber <oschreib at redhat.com> 2012-02-07 04:43:08 EST ---
I'm not a packager, so I can't be a sponsor yet.
Some comments though:

1. - Source in SRPM and URL does not match:
1cbb26be8d5d4be08e1f9f446b333a6f  fishpoll-0.1.5.tar.gz
e26e892ac14d19f766fd4409ca54530c  fishpoll-0.1.5.tar.gz.srpm

2. BuildRoot is no longer needed in Fedora.  Please remove.
3. BuildArch is not needed in Fedora.  Please remove.
4. %clean section is no longer needed in Fedora. Please remove this section.
5. The %install section should not contain anything that removes the buildroot.
 Remove: "rm -rf %{buildroot}"
5. rpmlint issues:
[oschreib at jerusalem fish]$ rpmlint fishpoll-0.1.5-1.fc16.noarch.rpm
fishpoll.noarch: W: name-repeated-in-summary C fishpoll
fishpoll.noarch: E: incorrect-fsf-address /usr/share/doc/fishpoll-0.1.5/COPYING
fishpoll.noarch: W: no-manual-page-for-binary fishpoke

looks like the COPYING is outdated, you should contact upstream to replace this
file with a newer one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.