[Bug 787364] Review Request: clipgrab - Streaming videos plate-forms grabber

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787364

Ofer Schreiber <oschreib at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oschreib at redhat.com

--- Comment #1 from Ofer Schreiber <oschreib at redhat.com> 2012-02-07 05:59:02 EST ---
I'm not a packager, so I can't be a sponsor yet.
Some comments though:

1. LICENSE is missing, you should contact upstream  so a LICENSE text will be
included in source tarball

2. The %defattr(-,root,root,-) entry is not needed in Fedora, unless you're
packaging for EPEL5.

3. Same for the "rm -rf RPM_BUILD_ROOT" in the beginning of %install

4. Why do you need the .desktop file as a source?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.