[Bug 786668] Review Request: python-sqlite3dbm - SQLite-backed dictionary conforming to the dbm interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=786668

--- Comment #5 from Stephen Gordon <sgordon at redhat.com> 2012-02-07 14:00:39 EST ---
I am not a packager, so can't approve the package, but I will have a swing at a
review.

[+] Complete
[-] Incomplete
[N/A] Not Applicable

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review. rpmlint issues the
following two warnings, which should be ignored in this case, on both the SRPM
and RPM:

python-sqlite3dbm.src: W: spelling-error Summary(en_US) dbm -> db, dim, dam
python-sqlite3dbm.src: W: spelling-error %description -l en_US dbm -> db, dim,
dam
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.

[-] MUST: The package must meet the Packaging Guidelines. Only due to other
incomplete issues noted in this review.

[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .

[+] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible. 

[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.

[-] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.

    Package build fails without python-setuptools. Should be in BuildRequires.

[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.

[-] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines

    As per previous incomplete item.

[N/A] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

[N/A] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.

[+] MUST: Packages must NOT bundle copies of system libraries.

[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. 

[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. 

[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)

[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.

[+] MUST: Each package must consistently use macros. 

[+] MUST: The package must contain code, or permissable content. 

[N/A] MUST: Large documentation files must go in a -doc subpackage. 

[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.

[N/A] MUST: Static libraries must be in a -static package.

[N/A] MUST: Development files must be in a -devel package.

[N/A] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency

[N/A] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

[N/A] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. 

[-] MUST: Packages must not own files or directories already owned by other
packages. I could be wrong here but I feel that the glob in the %files section
is to expansive. Instead of:

    %{python_sitelib}/*

I would suggest:

    %{python_sitelib}/sqlite3dbm

For example, this may prove difficult for the egg directory though, which
appears to include the python version in its name.

[+] MUST: All filenames in rpm packages must be valid UTF-8.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.