[Bug 787834] Review Request: fishpoll - Client programs for fishpoll server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787834

--- Comment #11 from Mario Santagiuliana <fedora at marionline.it> 2012-02-07 14:18:33 EST ---
Andrea thank you for your new package.

Please fix these few things:
1) use %{name} macro in Source0;
2) use %{name}-%{version} in %setup line instead of fishpoll-0.1.6
3) put systemd-units buildrequires under a if statement because this require is
needed just by fedora and not by EPEL.
4) in %install section move the two lines corresponding to SysV script in the
if-else statement, fedora 15+ use systemd not sysv.
5) same thing of 4) but for "%files server" section
6) add the requires systemd-units as explained here:
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#New_Packages
7) update your spec file for EPEL section in accord to:
http://fedoraproject.org/wiki/Packaging:SysVInitScript
so adding chkconfig and initscript requires etc.

Thank you

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.