[Bug 772751] Review Request: git-review - Helper for Gerrit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772751

--- Comment #7 from Pete Zaitcev <zaitcev at redhat.com> 2012-02-07 14:42:21 EST ---
1) I swear python_sitelib wasn't cargo-culted: it was in Packaging:Python.
However now it says "only for RHEL 5". Removed.

2) Group was commented as TODO to find the appropriate grou.
Using Development/Tools.

3) Fixed, split BuildRequires

4) Indeed apparently the syntax was incorrect, too. I do not have
"python-setuptools-devel" installed even, and RPM was building fine.

5) Added Requires: git. Nothing else comes to mind... Note that git-review
can form ssh:// URLs for git, but I do not want to saddle the package with
an extra requirement like this.

I have verified that all imported modules come from the standard library
and do not require additional Requires:.

6) Added %dir %{_sysconfdir}/git-review

7) Made tab-clean

8) Removed comment with %

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.