[Bug 787878] Review Request: mingw32-icu - MinGW compilation of International Components for Unicode Tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787878

Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |kalevlember at gmail.com

--- Comment #4 from Kalev Lember <kalevlember at gmail.com> 2012-02-07 17:20:14 EST ---
Michael, thanks for the comments. If you don't mind, I'll assign myself as the
official reviewer.


Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3770353

failed with:

i686-pc-mingw32-gcc  -I. -I../i18n  
"-DDEFAULT_ICU_PLUGINS=\"/usr/i686-pc-mingw32/sys-root/mingw/lib/icu\" "
-DU_ATTRIBUTE_DEPRECATED= -DU_COMMON_IMPLEMENTATION -DU_HAVE_ICUCFG  -O2 -g
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4
-mms-bitfields -Wall -ansi -pedantic -Wshadow -Wpointer-arith
-Wmissing-prototypes -Wwrite-strings -Wno-long-long -mthreads
-fvisibility=hidden -c -DPIC  -o putil.o putil.c
In file included from putil.c:65:0:
umutex.h:25:21: fatal error: intrin.h: No such file or directory
compilation terminated.

intrin.h doesn't appear to be available in the mingw.org headers. I know you
are using the mingw-w64 testing repo where the header probably exists, but the
official Fedora packages are based on the mingw.org toolchain instead and need
to build with it.

>From a quick look, intrin.h is conditionally included only if U_WINDOWS is
defined. One of the patches, icu4c-4_6_1-crossbuild.patch, contains the
following hunk that changes the build system to define U_WINDOWS instead of
U_MINGW:

--- a/source/configure
+++ b/source/configure
@@ -7736,7 +7736,7 @@
        *-*-hpux*)      platform=U_HPUX ;;
        *-apple-darwin*|*-apple-rhapsody*)      platform=U_DARWIN ;;
        *-*-cygwin*)    platform=U_CYGWIN ;;
-       *-*-mingw*)     platform=U_MINGW ;;
+       *-*-mingw*)     platform=U_WINDOWS ;;
        *-*ibm-openedition*|*-*-os390*) platform=OS390
                        if test "${ICU_ENABLE_ASCII_STRINGS}" != "1"; then
                                ICUDATA_CHAR="e"

Removing this from the patch made it build on koji.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.