[Bug 787878] Review Request: mingw32-icu - MinGW compilation of International Components for Unicode Tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=787878

--- Comment #5 from Kalev Lember <kalevlember at gmail.com> 2012-02-07 17:41:56 EST ---
With the small change to the source package outline in comment #4 to get it
building, rpmlint spews out a huge number of warnings / errors:

rpmlint output:
$ rpmlint mingw-icu-4.8.1.1-1.fc17.noarch.rpm \
          mingw-icu-4.8.1.1-1.fc17.src.rpm \
          mingw32-icu-debuginfo-4.8.1.1-1.fc17.noarch.rpm
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicule.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicuio.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicuuc.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicui18n.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicutu.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicutest.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicudata.dll.a
mingw-icu.noarch: E: arch-independent-package-contains-binary-or-object
/usr/i686-pc-mingw32/sys-root/mingw/lib/libiculx.dll.a
mingw-icu.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/unicode/chariter.h
mingw-icu.noarch: W: devel-file-in-non-devel-package
/usr/i686-pc-mingw32/sys-root/mingw/include/unicode/localpointer.h
[snip, some 200 more similar devel-file-in-non-devel-package warnings]
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicule.dll.a
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicuio.dll.a
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicuuc.dll.a
mingw-icu.noarch: W: dangling-relative-symlink
/usr/i686-pc-mingw32/sys-root/mingw/lib/icu/pkgdata.inc current/pkgdata.inc
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicui18n.dll.a
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicutu.dll.a
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicutest.dll.a
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libicudata.dll.a
mingw-icu.noarch: E: rpath-in-buildconfig
/usr/i686-pc-mingw32/sys-root/mingw/bin/icu-config lines ['100']
mingw-icu.noarch: W: spurious-executable-perm
/usr/i686-pc-mingw32/sys-root/mingw/lib/libiculx.dll.a
mingw-icu.noarch: W: non-standard-dir-in-usr i686-pc-mingw32

The core issue here is that the binary rpm is named 'mingw-icu', instead of
'mingw32-icu'. With correct naming rpmlint shouldn't output any of the warnings
above.

It would appear from the spec that it was the intention to name the binary
package mingw32-icu, but just a small oversight with %files section.

Instead of:
%files
it should be:
%files -n mingw32-icu


mingw-icu.noarch: W: no-documentation

Fedora MinGW packages are supposed to not contain documentation, but they MUST
have license files if the upstream tarballs has them. From a quick look,
upstream tarball has license.html and unicode-license.txt which need to be
packaged as %doc.


mingw-icu.noarch: W: dangling-relative-symlink
/usr/i686-pc-mingw32/sys-root/mingw/lib/icu/Makefile.inc current/Makefile.inc

Can probably just remove the dangling
/usr/i686-pc-mingw32/sys-root/mingw/lib/icu/Makefile.inc in %install


mingw-icu.src:71: W: configure-without-libdir-spec

This is fine, configure is just used for bootstrapping the mingw build.


mingw-icu.src:78: W: mixed-use-of-spaces-and-tabs (spaces: line 6, tab: line
78)

Would be nice to fix this to make rpmlint a bit quieter.


mingw-icu.src: W: invalid-url Source0:
http://download.icu-project.org/files/icu4c/${version}/icu4c-4_8_1_1-src.tgz
HTTP Error 404: Not Found

Looks like a typo, ${version} -> %{version}


mingw32-icu-debuginfo.noarch: E: debuginfo-without-sources
3 packages and 0 specfiles checked; 10 errors, 205 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.