[Bug 784950] Review Request: ktp-contact-applet - Telepathy contact plasmoid

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 8 08:04:55 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784950

Matthias Runge <mrunge at matthias-runge.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrunge at matthias-runge.de

--- Comment #3 from Matthias Runge <mrunge at matthias-runge.de> 2012-02-08 03:04:54 EST ---
Sorry for interrupting here.

nucleo, are you familar with 
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines ? 

I'd expect at least rpmlint output here. If this is to much work for you, you
might use fedora-review -b bug-number , to produce a review, run a mock-build
and rpmlint, etc.

You didn't note e.g. the following

[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install

I'm just observing, the form of this review is rather short and tends loose
sight of probably existing packaging errors. I do not mistrust approving *this*
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list