[Bug 788216] Review Request: python-elixir - Declarative mapper for SQLAlchemy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788216

Jamie Nguyen <jamie at tomoyolinux.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jamie at tomoyolinux.co.uk

--- Comment #1 from Jamie Nguyen <jamie at tomoyolinux.co.uk> 2012-02-08 06:12:35 EST ---
Some comments:

1) BuildRoot tag is no longer required
2) Removing %{buildroot} in the %install section is no longer required
3) %clean section no longer required
4) defattr in %files section is no longer required
5) Usually a LICENSE or COPYING file should be included if one has been
provided by upstream. Elixir actually has the LICENSE file in their source tree
[1] but strangely do not include it in their tarball. Perhaps this should be
included as Source1?

[1] http://elixir.ematia.de/trac/browser/elixir/tags/0.7.1/LICENSE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.