[Bug 788258] Review Request: perl-Module-Implementation - Loads one of several alternate underlying implementations for a module

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 8 15:07:51 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788258

--- Comment #2 from Paul Howarth <paul at city-fan.org> 2012-02-08 10:07:50 EST ---
> I suppose this is going to be in EPEL5, like many of your other packages.

It looks like EL-5 is going to be around for a long while yet, and I prefer to
keep things compatible whilst that's the case.

> FIX: The correct license for this package is Artistic 2.0

Fixed in -3; that was careless of me.

> TODO: perl(strict) and perl(warnings) don't live on CPAN, they could be safely
> removed from BRs

I've left them in in case they become dual-lived in future.

> TODO: However, perl(lib) does and should be added to your 'Test suite' BRs.

Added in -3.

> TODO: rpmbuild doesn't detect the perl(Carp) dependency here, you should
> Require it manually

Added in -3.

Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Module-Implementation/branches/fedora/perl-Module-Implementation.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Module-Implementation/perl-Module-Implementation-0.03-3.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list