[Bug 784958] Review Request: ktp-text-ui - Telepathy text chat handler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784958

nucleo <alekcejk at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |alekcejk at googlemail.com
               Flag|                            |fedora-review?

--- Comment #22 from nucleo <alekcejk at googlemail.com> 2012-02-10 22:05:31 EST ---
http://trac.adium.im/wiki/mathuaerknedam ansered me on #adium-devl that he will
look on fadomatic issue, ktp will follow for adium changes
http://mail.kde.org/pipermail/kde-telepathy/2012-February/005434.html

MUST Items:
+ rpmlint output
  $ rpmlint ktp-text-ui-0.3.0-6.fc16.i686.rpm ktp-text-ui-0.3.0-6.fc16.src.rpm
ktp-text-ui-debuginfo-0.3.0-6.fc16.i686.rpm
ktp-text-ui-devel-0.3.0-6.fc16.noarch.rpm
    ktp-text-ui.i686: E: invalid-soname /usr/lib/libktpchat.so libktpchat.so
(ignored for now until upstream made it versioned)
    ktp-text-ui.i686: E: zero-length
/usr/share/kde4/apps/ktelepathy/styles/simkete/Contents/Resources/Header.html
(can be ignored because files can be used somehow)
    ktp-text-ui.i686: E: zero-length
/usr/share/kde4/apps/ktelepathy/styles/simkete/Contents/Resources/Footer.html
    ktp-text-ui.i686: W: file-not-utf8 /usr/share/doc/ktp-text-ui-0.3.0/Renkoo
LICENSE.txt (no easy way to fix it because file was made from files with
different encodings in wrong way)
    ktp-text-ui-devel.noarch: W: no-documentation
    4 packages and 0 specfiles checked; 3 errors, 2 warnings.
+ named and versioned according to the Package Naming Guidelines.
  Package name match the upstream tarball name ktp-text-ui-0.3.0.tar.bz2
+ spec file name ktp-text-ui.spec matches base package name
+ complies with all the legal guidelines:
  + License: GPLv2+ and (BSD or AFL) and MIT valid, matches actual license
(added notices for parts under different licenses)
  + No known patent problems
  + No emulator, no firmware, no binary-only or prebuilt components
+ COPYING (GNU GENERAL PUBLIC LICENSE Version 2), README (MIT license), Renkoo
LICENSE.txt (BSD and AFL license) packaged as %doc
+ source matches upstream:
  MD5: 893b1eeb962ef2ba79244147c7051e0e  ktp-text-ui-0.3.0.tar.bz2
  SHA1: b9ba195904d470835e404f37073ed36fc510c791  ktp-text-ui-0.3.0.tar.bz2
  SHA256: f735708db55367ab37aa9b21af48ae7390022ba3a9b7c2ee9b369d430df79fa0 
ktp-text-ui-0.3.0.tar.bz2
+ builds on at least one arch
  build from mock is in F16 kde-unstable repo
+ no known non-working arches, so no ExcludeArch needed
+ no missing BuildRequires (builds in mock)
+ locales are handled properly by using %find_lang %{name} --all-name
--with-kde macro
+ ldconfig call used (needed for %{_kde4_libdir}/libktpchat.so shared library)
+ no duplicated system libraries
+ package not relocatable (no Prefix tag)
+ directory ownership correct (doesn't own directories owned by another
package, owns all package-specific directories)
+ no duplicate files in %files
+ permissions correct, %defattr(-,root,root,-) not needed now, executables have
executable permissions
+ macros used where possible (%{name}, %{version}, %{buildroot},
%{_target_platform}, %{cmake_kde4}, %{_kde4_libexecdir}, %{_kde4_libdir},
%{_kde4_datadir}, %{_datadir})
+ non-code content: only permitted content, chat theme, have open source
compatible licenses
+ no large documentation files, so no -doc package needed
+ no %doc files required at runtime
+ header files packaged in -devel subpackage
+ no static libraries, so no -static package needed
+ no devel symlinks which would need to be in a -devel subpackage (in noarh
-devel only headres)
+ devel packages must require the base package
+ no .la files
+ no .desktop file needed in /usr/share/applications for this KDE Telepathy
internal module
+ desktop-file-validate call not needed for service type .dsktop files
installed in %{_kde4_datadir}/kde4/services
+ all filenames are valid UTF-8
+ other packaging guidelines:
  + complies with the Filesystem Hierarchy Standard (all files in
%{_kde4_libexecdir}, %{_kde4_libdir} and %{_datadir})
  + proper changelog, tags, BuildRequires, Summary, Description (used the only
available description from upstream)
  + no non-UTF-8 characters (except Renkoo LICENSE.txt which have mostly
cosmetic defects)
  + all relevant documentation included as %doc (COPYING README, Renkoo
LICENSE.txt)
  + RPM_OPT_FLAGS are used in %{cmake_kde4} macro
  + debuginfo package is valid (contains stripped symbols from ELF binary and
source code related to it)
  + no rpaths (no check-rpaths error)
  + no configuration files, so %config guideline doesn't apply
  + no init scripts, so init script guideline doesn't apply
  + timestamps are preserved
  + %{?_smp_mflags} used
  + not a web application, so web application guideline doesn't apply
  + no conflicts

SHOULD Items:
+ license already included upstream
+ no translations for description and summary provided by upstream
+ package builds in mock (built for kde-unstable)
- successfully tested the package functionality (no testing yet)
+ scriptlets are sane (%post -p /sbin/ldconfig, %postun -p /sbin/ldconfig)
+ subpackages other than devel should require the base package using a fully
versioned dependency (no subpackages other than devel, devel have fully
versioned dependency)
+ no .pc files, so "placement of .pc files" is irrelevant
+ no file dependencies
+ no binaries/scripts that needs man pages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.