[Bug 788080] Review Request: python-xhtml2pdf - HTML/CSS to PDF converter based on Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=788080

massimo.paladin at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |massimo.paladin at gmail.com

--- Comment #1 from massimo.paladin at gmail.com 2012-02-13 05:19:29 EST ---
Hi Matthias,

I am not a package maintainer so I can only make an informal review, here are
some notes:

* build is recommended to be: CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py
build
* is there a specific reason to have -O1 in the install command?
* I think you should be more explicit in files section to detect when egg build
fail with something like:
%{python_sitelib}/%{pkgname}-%{version}-py?.?.egg-info
%{python_sitelib}/%{pkgname}/
* probably you should explicitly set executable on the two scripts in bindir
* you should also provide man pages for the two bindir scripts as it is
recommended

It builds in mock and the rest looks fine to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.